Closed DougBurke closed 4 years ago
@ericmandel can you try this out and see if it works. Then we can decide if its okay or needs a rework.
Sure but can you please remind me how to install your trial version? I clone it but when I do:
pip3 install pyds9
in the clones directory, it downloads my repository, not the one I am sitting in. Frustrating!
Oh wait, I tried:
pip3 install ./pyds9
which might be doing something better ...
I tend to create a new conda environment, and then install into that (or use develop mode). I'm not sure what you're environment is, so I don't want to accidentally break things. I think that
pip3 install -e .
(when in the pyds9/ directory) eg https://stackoverflow.com/questions/42609943/what-is-the-use-case-for-pip-install-e can be useful here
This code change works for me in the following situations:
There is a print statement in the code that you will want to remove:
print("- checking [{}]".format(pline, idx))
cause it prints about a billion lines on my Mac. Other than that, thanks, this should be great.
Doh. I thought I'd taken out the debug statement.
I've just force-pushed a change so that the debug line never existed.
Thanks, I merged it and now will test it as a new user ...
Still works, I think we have winner here ... thanks.
This attempts to make the check for an already-running DS9 process a bit more robust. It's not ideal, and will not work on Windows (but the existing code doesn't either), but is hopefully an improvement.
My current test set up doesn't let me test this (I don't have the time/energy to change my environment to address this).