search

ericmatthys / grunt-changelog

MIT License
45 stars 10 forks source link

package.json/main refers to Gruntfile.js #20

Closed silkentrance closed 9 years ago

silkentrance commented 10 years ago

Please make this point to tasks/changelog.js instead.

The reason for this being that I want to hide certain tasks as they will not work as expected in my build process which targets both NPM and Meteor package builds. As such I need to require('grunt-changelog') and then late bind the task associated with it. Having require returning me your Gruntfile renders this task unusable for me.

silkentrance commented 10 years ago

I settled with require('grunt-changelog/tasks/changelog') for the moment. So we might as well close this one unless you feel that pointing main to your gruntfile is inherently wrong :D

ericmatthys commented 9 years ago

Why are you requiring the task instead of using grunt to load the task? The grunt-contrib-* tasks do not include a main any longer in their package.json. I don't think we should stray from the standard set by them.

silkentrance commented 9 years ago

The reason I do this is that I build a wrapper task for grunt-changelog and do not want the user to invoke the original changelog task, therefore I am late binding it.

mischah commented 9 years ago

I see your point and think it’s absolutely valid to reference tasks/changelog.js with the main property.

Please create a PR to merge your change into the develop branch :octocat:

silkentrance commented 9 years ago

Hm, ericmatthys pointed out that grunt tasks do no longer include a main, perhaps removing it altogether seems to be the better approach?

mischah commented 9 years ago

main property is gone with PR #35 which landed in development branch.