search

ericmatthys / grunt-changelog

MIT License
45 stars 10 forks source link

Fixes #46 #50

Closed silkentrance closed 6 years ago

silkentrance commented 9 years ago

Needs PR #39 as it is based on the custom sections patch.

Readme still needs some work, documenting the new option.

silkentrance commented 9 years ago

@ericmatthys Please have a look and tell me if this is what you want. The readme still needs to be update but that is something I can do as soon as the patch is ready. This time it is the correct issue and the correct branch SIGH...

silkentrance commented 9 years ago

@mischah Perhaps you might want to have a look at this?

mischah commented 9 years ago

Looks like a lot of code for a usecase which seems a bit exotic to me :laughing: But it doesn’t mean that this one won’t be merged just because I don’t feel the need for this.

Any thoughts on that @ericmatthys?

ericmatthys commented 9 years ago

In general, the project has tried to be flexible, which is why templating is included in the first place. However, at some point, we have to draw a line and say this is better off for a fork rather than the main project. I'm tempted to put this on the other side of that line just because it does seem like a niche case and it adds a fair bit of complexity to achieve it.

silkentrance commented 9 years ago

While I don´t think that singleLineParser with its additional 30 or so lines of extra code adds that much complexity to the project, feel free to reject this as you like. I might consider creating a fork from this, for the time being I will simply use my repository instead.

silkentrance commented 6 years ago

@ericmatthys it seems as if no one needs this change. And since I have moved on, I will close this in order to get rid of it.