search

ericmckean / game-music-emu

Automatically exported from code.google.com/p/game-music-emu
GNU Lesser General Public License v2.1
0 stars 0 forks source link

[PATCH] Read song length information for SAP #29

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. In .sap files, reading the TIME entry was missing.

Please provide any additional information below.
In the attached patch the TIME entry is read. 'Loop' hint in the same line is 
ignored.

Original issue reported on code.google.com by wbb1...@gmail.com on 8 Nov 2013 at 6:56

GoogleCodeExporter commented 9 years ago

Original comment by wbb1...@gmail.com on 8 Nov 2013 at 6:57

Attachments:

GoogleCodeExporter commented 9 years ago 
I took a look at the patch today. I don't think it can go in as-is because the 
extra global array would cause Sap_Emu to be non-reentrant. I started working 
on a quick pass of integrating the track info directly into the class decl, but 
adding it to the end of the class (to keep binary compatibility) would need 
code changes in parse_info (which doesn't know about its parent Sap_Emu), and 
adding the track info to the Sap info_t would break binary compatibility.

I'll think of something, but it won't be tonight.

Original comment by michael....@gmail.com on 24 Jun 2014 at 12:37

GoogleCodeExporter commented 9 years ago 
Sorry about the global. Was done in a hurry, but I understand the problem now. 
The only possible way I see is to add it to Sap info_t.

Original comment by wbb1...@gmail.com on 8 Jul 2014 at 6:47