ericmckean / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

ISO 8601 dates not supported in cell editing - cell-ui.js #488

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Dates formatted in ISO 8601 format can't be converted to a date by the 
individual cell editor cell-ui.js  This is ironic since that's the format that 
converts dates to when creating strings.

An example which doesn't work 1987-08-01T03:00:00Z

Apparently Javascript 5 will include better parsing, but until then, the 
Date.parse() needs to be replaced with something else here:

    } else if (type == "date") {
      value = Date.parse(text);
      if (!value) {
        alert("Not a valid date.");
        return;
      }
      value = value.toString("yyyy-MM-ddTHH:mm:ssZ");

Original issue reported on code.google.com by tfmorris on 18 Nov 2011 at 10:21

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2388.

Original comment by dfhu...@google.com on 27 Nov 2011 at 8:23

GoogleCodeExporter commented 9 years ago

Original comment by dfhu...@google.com on 11 Dec 2011 at 10:35

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 12 Dec 2011 at 7:41