search

ericmckean / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

Incorrect service registration disables the user interface #584

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Register an incorrect service URI causes that the "Working...." dialog is never 
disabled.

The non-secure code is located at the 
ReconciliationManager.registerStandardService function (recon-manager.js:77). 
The $.getJSON function doesn't accept a timeout parameter, which could be a way 
to solve this issue. 

Source of the issue: https://github.com/fadmaa/grefine-rdf-extension/issues/58

Original issue reported on code.google.com by sergio@wikier.org on 18 Jun 2012 at 3:07

GoogleCodeExporter commented 9 years ago 
Some people are already tried to add timeout support to $.getJSON, for 
instance: 
http://maheshbokkisam.blogspot.co.at/2012/03/jquery-getjson-with-timeout.html

Original comment by sergio@wikier.org on 18 Jun 2012 at 3:10

GoogleCodeExporter commented 9 years ago 
The attached patch will handle such problem. Maybe it'd nice to report the user 
about such problem, but at least this solves the issue.

Original comment by sergio@wikier.org on 29 Jun 2012 at 7:18

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 18 Sep 2012 at 8:18

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 12 Oct 2012 at 7:18

GoogleCodeExporter commented 9 years ago 
Fixed in r2580.  I added error reporting as well as a 10 second timeout for 
reconciliation service to reply within.  Thanks for investigating and getting 
the patch started.

Original comment by tfmorris on 12 Oct 2012 at 10:31

GoogleCodeExporter commented 9 years ago 
You are welcome! Thanks.

Original comment by sergio@wikier.org on 15 Oct 2012 at 11:04