ericmckean / google-url

Automatically exported from code.google.com/p/google-url
Other
0 stars 0 forks source link

[PATCH] Make library portable and cmake build system #22

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The attached patch makes current svn trunk portable on Linux platform (minor 
headers such as windows.h were included in some source parts, some win32 only 
functions were used etc.).

I move the headers into a separate directory and created a CMake project to 
make it able to generate Visual Studio projects and makefiles for Linux.

Original issue reported on code.google.com by sebastie...@gmail.com on 16 Feb 2011 at 6:09

Attachments:

GoogleCodeExporter commented 9 years ago
Anyone still working on this library? No answer == dead project?

Original comment by sebastie...@gmail.com on 18 Feb 2011 at 10:03

GoogleCodeExporter commented 9 years ago
Code reviews for this normally are managed through the Chromium code review 
system:
http://www.chromium.org/developers/contributing-code

Also, you can't move files around without breaking other projects, and even if 
you could, it makes your other changes impossible to review.

Original comment by bre...@gmail.com on 18 Feb 2011 at 7:35

GoogleCodeExporter commented 9 years ago
OK. Thank you very much for the update! Do not hesitate to ask me to update a 
few things if needed.

Original comment by sebastie...@gmail.com on 18 Feb 2011 at 9:26