ericmckean / google-url

Automatically exported from code.google.com/p/google-url
Other
0 stars 0 forks source link

EOF not declared in string16.h #6

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Compiling an application including google-url on a linux machine with GCC
4.4.0 throws the following error:

In file included from include/google-url/src/gurl.h:36,
                 from include/google-url/src/gurl.cc:38:
include/google-url/base/string16.h: In static member function ‘static int
base::string16_char_traits::eof()’:
include/google-url/base/string16.h:140: error: ‘EOF’ was not declared in
this scope

A trivial patch has been attached.

Original issue reported on code.google.com by VeXoc...@gmail.com on 7 May 2009 at 9:44

Attachments:

GoogleCodeExporter commented 9 years ago
To summarize, string16.h needs stdio.

This file is forked from Chromium's to googleurl can compile by itself:
http://src.chromium.org/viewvc/chrome/trunk/src/base/string16.h

Chromium's has stdio, so it works for us. I'll add this (as <stdio.h> rather 
than 
<cstdio> to match Chromium's) when I get back from vacation.

Original comment by bre...@gmail.com on 7 May 2009 at 9:56

GoogleCodeExporter commented 9 years ago
This is fixed in the patch written for issue 22
http://code.google.com/p/google-url/issues/detail?id=22

Original comment by sebastie...@gmail.com on 16 Feb 2011 at 6:11