Bug in roster module. on delete contact

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. use talk\xmpp\rostermoduleimpl.h
2. Use two contacts. Both of them "see" only each other. So roster contains 
only one contact.
3. remove contact from the roster (e.j. kick from the roster on the server 
side).
4. counter part will have an error in use rostermoduleimpl.cc

small defect in talk\xmpp\rostermoduleimpl.h
it has uncommented line:
IMPLEMENT_XMPPMODULE

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
libjingle rev 155
win 7
VS2008

Please provide any additional information below.

Original issue reported on code.google.com by rodionma...@gmail.com on 25 Jun 2012 at 1:31

GoogleCodeExporter commented 9 years ago

Original comment by rodionma...@gmail.com on 25 Jun 2012 at 1:32

Attachments:

rostermoduleimpl.cc.patch

GoogleCodeExporter commented 9 years ago

sorry for the IMPLEMENT_XMPPMODULE. its not a problem

Original comment by rodionma...@gmail.com on 25 Jun 2012 at 1:46

GoogleCodeExporter commented 9 years ago

found another problem in roster module. XmppRosterContactImpl::GetGroupCount() 
has next line:
ASSERT(group_count > 0); // protect the cast
Is it really needed? 
It is possible that there will be no grouping(i have such roster). In this case 
this function will raise an exception.

Original comment by rodionma...@gmail.com on 26 Jun 2012 at 7:08

ericmckean / libjingle

Bug in roster module. on delete contact #363