ericmckean / living-stories

Automatically exported from code.google.com/p/living-stories
0 stars 0 forks source link

Show an error for malformed timestamps #10

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a narrative or event.
2. In the timestamp field, enter a time without an am/pm designation
3. Look at your living story page.  Everything will fail

What is the expected output? What do you see instead?
A malformed timestamp should generate an error in the compose page rather 
than getting accepted and then totally breaking the page.

Original issue reported on code.google.com by ericzh...@google.com on 4 May 2010 at 10:37

GoogleCodeExporter commented 9 years ago
Thanks for isolating this! In a combination of 
curiosity/irritation/love-of-simplicity: why is it that there is a 
separate, required, time field?

Original comment by byjoeyba...@gmail.com on 4 May 2010 at 11:26

GoogleCodeExporter commented 9 years ago
There's actually already another bug filed about making the timestamp optional, 
which 
we plan to fix shortly.

The basic reason is: we use the date/time to sort the events in your living 
story 
page.  We were assuming that you'd always want to put a time down, but it seems 
that 
many people want to omit it, so we'll default that to 12:00 AM and hide it.

Original comment by ericzh...@google.com on 4 May 2010 at 11:45