search

ericmckean / make-open-easy

Automatically exported from code.google.com/p/make-open-easy
0 stars 0 forks source link

git config throws key errors for things that should be optional #1

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Our public repository config was

 "public_repository": {
  "type": "git",
  "url": "ssh://git@github.com:facebook/project_name.git"
 },

It threw a key exception for branch, so I added master as the branch then it 
threw a key exception for gerrit_autoapprove.

Small Stacktrace:

  File "/usr/local/lib/python2.6/dist-packages/moe-0.1-py2.6.egg/moe/config.py", line 187, in MoeProjectConfigFromJson
    project_space=base.PUBLIC_STR)
  File "/usr/local/lib/python2.6/dist-packages/moe-0.1-py2.6.egg/moe/config.py", line 274, in MakeRepositoryConfig
    project_space=project_space)
  File "/usr/local/lib/python2.6/dist-packages/moe-0.1-py2.6.egg/moe/git.py", line 469, in __init__
    self.gerrit_autoapprove = config_json['gerrit_autoapprove']

Original issue reported on code.google.com by sc...@macvicar.net on 7 Apr 2011 at 11:27

GoogleCodeExporter commented 9 years ago 
Diff attached

Original comment by sc...@macvicar.net on 7 Apr 2011 at 11:33

Attachments:

GoogleCodeExporter commented 9 years ago 
Test that email is working

Original comment by dbentley@google.com on 12 Apr 2011 at 2:34