ericmckean / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Minify_HTML + IE8 "Internet Explorer cannot display the webpage" #110

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Minify version: 2.1.2
PHP version: 5.2.6

What steps will reproduce the problem?
1. Copy source code from http://www.deafzone.ch/
2. Minify it with the HTML minifier only.
3. Load it in Internet Explorer 8.0 et volià the message "Internet Explorer
cannot display the webpage".

When commenting out these lines in the class Minify_HTML
Line 65: $this->_html = str_replace("\r\n", "\n", trim($html));
Line 123: $this->_html = preg_replace('/^\\s+|\\s+$/m', '', $this->_html);

Then it'll works.

By the way, you aren't trimming tabulators, please also add the \t in your
logic.

Thanks.

Michael H.

Original issue reported on code.google.com by michael....@gmail.com on 1 May 2009 at 3:26

GoogleCodeExporter commented 9 years ago
I just added in R326 a tool to test Minify_HTML output in the browser. At first 
inspection, Minify_HTML output of your home page source validates and displays 
in 
Opera, but I'll test this in very IE8 soon.

Re: tabs, can you give me a specific piece of markup from which tabs aren't 
removed?

Original comment by mrclay....@gmail.com on 1 May 2009 at 5:21

GoogleCodeExporter commented 9 years ago
Oh, for the tab problem, I used another source code, from 
www.bonauer-architekten.ch:
The part for the SWFObject beginning with var flashvars=false; contains tabs 
which
aren't removed.

Thanks for the examination!

Michael

Original comment by michael....@gmail.com on 2 May 2009 at 2:18

GoogleCodeExporter commented 9 years ago
Michael, Can you still verify this bug exists in Minify 2.1.3? The lines you 
commented 
out just remove whitespace and convert line endings.

Original comment by mrclay....@gmail.com on 9 May 2010 at 3:43

GoogleCodeExporter commented 9 years ago
Thanks for asking but I am afraid I reported the bug 1 year ago. A lot has 
changed
since then, i.E. we're using something else and now I am unable to reproduce 
that.

But you can copy the HTML code of www.deafzone.ch and test this yourself.

Cheers

Michael

Original comment by heuberge...@gmail.com on 10 May 2010 at 3:34