search

ericmckean / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Need a "f=" version of Minify_buildUri() #130

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Pseudocode:

function Minify_pathsToUri($paths, $modRewriteWorks = false) {
  // $paths has strings like "//path/to/file.js"
  // converted into array of complete file paths
  // $mtime = max(filemtime(file1), filemtime(file2), ...)
  // construct URI
  $root = $modRewriteWorks ? "/min/f=" : "/min/?f=";
  return $root . implode(',', $shortPaths) . "&" . $mtime;
}

Original issue reported on code.google.com by mrclay....@gmail.com on 6 Aug 2009 at 12:05

GoogleCodeExporter commented 9 years ago 
there is a problem with this function

$root = $modRewriteWorks ? "/min/f=" : "/min/?f=";
return $root . implode(',', $shortPaths) . "&" . $mtime;

modRewriteWorks: false
http://examplem.com/min/?g=keyName&1111

modRewriteWorks: true
http://examplem.com/min/g=keyName&1111 the second url starts with & and ? is 
missing. For me the browsers doesn't take the version number it should be 
http://examplem.com/min/g=keyName?1111 because it was rewriten

Original comment by ciprian.mihalache@originals.ro on 23 Apr 2014 at 5:56

GoogleCodeExporter commented 9 years ago 
What do you mean the "browser doesn't take the version number"?

Original comment by mrclay....@gmail.com on 23 Apr 2014 at 12:27