ericmckean / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Behaviour of Cache-Control headers in combination with debug flag #157

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Minify version: 2.1.3
PHP version: 5.3.1

What steps will reproduce the problem?
1. Edit config.php
2. Set $min_allowDebugFlag = true
3. Load any minified js/css file(s)

Expected output:
Cache-Control   max-age=1800, public

Actual output:
Cache-Control   max-age=0, no-store

Did any unit tests FAIL? (Please do not post the full list)
No

This is more a request for change than a bug report: Please change the
behaviour of Cache-Control headers so that it only outputs max-age=0 when
debug mode is really USED by GET parameter ?debug=true, not when it's
solely useable by config entry.

Original issue reported on code.google.com by al...@nurfuerspam.de on 1 Feb 2010 at 2:18

GoogleCodeExporter commented 9 years ago
Minify has no "no-store" option. Also $min_allowDebugFlag is never passed into 
the
server. The 'debug' server option is set if and only if both the allow is set 
AND the
GET var is present. See line 34:
http://code.google.com/p/minify/source/browse/tags/release_2.1.3/min/index.php#3
4 

I think you're either seeing that in your browser's request headers, or the 
response
is being altered by your server for some reason (outside of PHP). Mail me a URL 
or
post the Request/Response headers you get from Firebug's Net panel.

Original comment by mrclay....@gmail.com on 1 Feb 2010 at 3:19

GoogleCodeExporter commented 9 years ago
You were right, the headers were changed by our CDN. I'm sorry. Feel free to 
close
this ticket.

Original comment by al...@nurfuerspam.de on 1 Feb 2010 at 7:03

GoogleCodeExporter commented 9 years ago

Original comment by mrclay....@gmail.com on 23 Apr 2010 at 3:09