ericmckean / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Builder does not work with HTTPS #158

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Minify version: 2.1.3
PHP version: 5.2.6

What steps will reproduce the problem?
1. Put min under SSL protected site, like https://www.mydomain.com/min

this will led to 404 error when add a file.

Original issue reported on code.google.com by alexlv...@gmail.com on 1 Feb 2010 at 6:09

GoogleCodeExporter commented 9 years ago
Open up min/builder/_index.js to line 71:
http://code.google.com/p/minify/source/browse/tags/release_2.1.3/min/builder/_in
dex.js#71

CHANGE:
var url = 'http://' + location.host + '/' 
TO:
var url = location.protocol + '//' + location.host + '/'

Does this fix?

Original comment by mrclay....@gmail.com on 1 Feb 2010 at 7:04

GoogleCodeExporter commented 9 years ago
BTW, if not, you should open up Firebug's Net tab and see why the requests are 
failing.

Original comment by mrclay....@gmail.com on 1 Feb 2010 at 7:05

GoogleCodeExporter commented 9 years ago
it works for me now, thanks a lot!

Original comment by alexlv...@gmail.com on 2 Feb 2010 at 10:32

GoogleCodeExporter commented 9 years ago
I can confirm that the fix works.

Original comment by ze...@zero3.dk on 1 Mar 2013 at 1:32

GoogleCodeExporter commented 9 years ago
Fixed on github, have not mirrored here yet
https://github.com/mrclay/minify/commit/cb75a4fd30a11ebd7d445347b31a2ec2197cc713

Original comment by mrclay....@gmail.com on 1 Mar 2013 at 2:29

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
@locationroura Seek help on the Minify google group.

Original comment by mrclay....@gmail.com on 31 May 2013 at 5:10