ericmckean / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Minify CommentPreserver should leave /*! intact. #232

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Minify version:
PHP version:

What steps will reproduce the problem?
1. Minify any output with preserving C-style comments
2.
3.

Expected output:
  Minified content with preserved comments as is.

Actual output:
  Minified content with modified preserved comment.
  i.e. /*! */ replaced with /* */

Did any unit tests FAIL? (Please do not post the full list)

Please provide any additional information below. If this has to do with URI
rewriting, please include your DOCUMENT_ROOT, the

By stripping the preserving style tag there is an expectation that comments can 
be removed if "double minified". A quick example of this is Google Page Speed 
recommending minifying minified output for potential savings (remove the now 
non preserved comments).

Original issue reported on code.google.com by cra...@togetheragency.co.uk on 18 May 2011 at 3:49

GoogleCodeExporter commented 9 years ago
Agreed.

Original comment by mrclay....@gmail.com on 18 May 2011 at 6:08

GoogleCodeExporter commented 9 years ago
2.1.4 branch already preserves the "!".

Original comment by mrclay....@gmail.com on 23 Jun 2011 at 7:40

GoogleCodeExporter commented 9 years ago
Sorry, I was not aware that this was trunk specific. Was this functionality 
reverted for a specific reason?

Original comment by cra...@togetheragency.co.uk on 4 Jul 2011 at 9:54

GoogleCodeExporter commented 9 years ago
The SVN trunk should be identical to the "current" release, 2.1.3. FYI the 
active branch of what will be 2.1.4 is now here: 
https://github.com/mrclay/minify

Original comment by mrclay....@gmail.com on 5 Jul 2011 at 3:52