search

ericmckean / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Issue with comments #88

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Minify version:
PHP version: 5.2.6
(minify 2.1.1)

What steps will reproduce the problem?
1. Add swfobject within a signle grouped JS, alog with any other libraries
after and before
2. Check with firebug

Expected output:
No errors with firebug

Actual output:

{PREVIOS JS}**Swobject*{FOLLOWING JS FILES}

Please provide any additional information below.
The javascript had a comment like this:
/**
 * SWFObject v1.5: Flash Player detection and embed
 *
 * http://www.opensource.org/licenses/mit-license.php
 *
 */

Original issue reported on code.google.com by netnotio...@googlemail.com on 21 Feb 2009 at 5:52

GoogleCodeExporter commented 9 years ago 
2.1.2b has several Javascript fixes. Can you see if the problem still exists 
with 
that beta:
http://groups.google.com/group/minify/browse_thread/thread/8add5761eb27d67d

I'm going to guess the problem is due to your first file ending with a comment.

Original comment by mrclay....@gmail.com on 21 Feb 2009 at 8:17

GoogleCodeExporter commented 9 years ago 
It works perfect with this version! I think I will use it even although is a 
beta..
until I see another problem (and report it)

And you're right. The first file ended with:
"//-->"

Let me know if there's any way I can help

Original comment by netnotio...@googlemail.com on 22 Feb 2009 at 3:58

GoogleCodeExporter commented 9 years ago

Original comment by mrclay....@gmail.com on 23 Feb 2009 at 1:46