search

ericmckean / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

Get rid of extern function prototypes in .cpp files by including appropriate headers. #112

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
A quick code search shows about 97 of these:

https://code.google.com/p/chromium/codesearch#search/&q=extern%5Cs%2B%5B%5E%22%5
D%20file:pdfium/%20file:.cpp&sq=package:chromium&type=cs

The problem is that when the function is modified, and the one true header 
providing its prototype is updated, we want the compilation to break if there 
are still unmodified callers.  Having these sprinkled throughout .cpp files 
makes this impossible, and we may end up crashing later on.

I ran into this while trying to change one such function and decided to give up 
until the problem as a whole was rectified.

Original issue reported on code.google.com by tsepez@chromium.org on 26 Jan 2015 at 11:35