ericmckean / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Can't download raw version of large patches #196

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Upload a large patch to rietveld for review
2. Try to download it with "git cl patch" or just getting the raw patch on 
the web interface

What is the expected output? What do you see instead?

* Can't download the patch. The web interface says "Patch set is too large 
to download".

What version of the product are you using? On what operating system?

Whatever codereview.chromium.org is running

*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***

(I am a google employee)

Please provide any additional information below.

From email from John Abd-El-Malek:

The reason is App Engine's datastore limits.  After this was implemented, 
AE added an experimental blob API which we might be able to use, but no one 
has used it for extra large patches.  You can file a feature request on 
Rietveld's bugtracker.

Original issue reported on code.google.com by olofj@google.com on 11 May 2010 at 11:16

GoogleCodeExporter commented 9 years ago

Original comment by john.abd...@gmail.com on 12 May 2010 at 2:02

GoogleCodeExporter commented 9 years ago
Is it still an issue? Can you post the link?

Original comment by techtonik@gmail.com on 8 Nov 2011 at 9:38

GoogleCodeExporter commented 9 years ago
We ditched rietveld months ago, no idea.

Original comment by olofj@google.com on 8 Nov 2011 at 9:50

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 7:41

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
This is still an issue, here's an example 
https://codereview.appspot.com/63760043/#ps80001

Original comment by arnold.k...@gmail.com on 17 Feb 2014 at 7:23

GoogleCodeExporter commented 9 years ago
Another example: https://codereview.chromium.org/307793002/#ps20001

Blobstore should be a much better place to store patches...

Original comment by justinfagnani@google.com on 30 May 2014 at 10:00