ericmckean / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

No proportional font in emails makes diffs unreadable #288

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Diffs in Rietveld emails are mostly useless for Python code, because they have 
badly formatted indentation. I wonder what it takes to force diffs in these 
email be in proportional font?

Original issue reported on code.google.com by techtonik@gmail.com on 31 Mar 2011 at 9:07

GoogleCodeExporter commented 9 years ago
Don't we send out mails in plain text? 

See for example: 
https://groups.google.com/group/codereview-discuss/msg/5de3275f709aa52d?dmode=so
urce&output=gplain&noredirect

Original comment by albrecht.andi on 31 Mar 2011 at 9:13

GoogleCodeExporter commented 9 years ago
Seems like we are. But GMail still uses non-proportional font to display these 
mails. Is it possible to force it?

By the way - diff in email is different from original diff below - seems like 
there is a bug with rendering anyway.
http://codereview.appspot.com/download/issue4173059_1_2.diff

Original comment by techtonik@gmail.com on 31 Mar 2011 at 2:53

GoogleCodeExporter commented 9 years ago
You're right, the diff in the mail differs from the diff that can be 
downloaded. But I'm not sure where this happens. AFAICT what we send out is 
fine, but seems to get modified at some point after we've sent it.

I'm using a simple stylebot (a Chromium extension) snippet to have monospaced 
fonts in my Gmail mails:
.gt {
  font-family: monospace;
}

Original comment by albrecht.andi on 1 Apr 2011 at 1:01

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 7:25

GoogleCodeExporter commented 9 years ago
techtonik: Just came across this issue, isn't this a "wontfix"?

Original comment by albrecht.andi on 7 Jul 2012 at 7:04

GoogleCodeExporter commented 9 years ago
There are two approaches:

(1) Using MIME multipart/message (or whatever it is) to send out two versions 
of the body, one as plain text and one as HTML using <pre> to format the diffs. 
 This is not impossible but a lot of work (and remember to quote characters 
like < & >).

(2) Use GMail "view original".

I think if someone contributes a patch for (1) we would accept it (assuming it 
passes code review) so I don't think we should close this as won't fix.  But 
for me personally it's a don't care. :-)

Original comment by gvanrossum@gmail.com on 7 Jul 2012 at 7:37

GoogleCodeExporter commented 9 years ago
I am for (1). Where are the main hurdles for producing MIME multipart/messages 
mails with Rietveld? Are there primarily AppEngine, Python or MIME limitations?

Original comment by techtonik@gmail.com on 7 Jul 2012 at 8:50

GoogleCodeExporter commented 9 years ago
It's just a matter of writing some code. The App Engine email API supports it.

Original comment by gvanrossum@gmail.com on 7 Jul 2012 at 11:20