search

ericmckean / sawbuck

Automatically exported from code.google.com/p/sawbuck
1 stars 0 forks source link

Disassembly fix #30

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The disassembler should not disassemble past call to a non-returning function. 
As-is, this occurs a few times during Chrome.dll disassembly, but AFAICT the 
disassembly either flows into the adjoining basic block, or terminates on 
reaching switch jump tables.

Original issue reported on code.google.com by siggi@chromium.org on 4 Mar 2011 at 7:42

GoogleCodeExporter commented 9 years ago 
As the Decomposer object has knowledge of which functions are non-returning, a 
simple fix to this would be to extend the OnInstruction callback return type to 
indicate three states: continue, terminate-all-disassembly, and 
terminate-function-disassembly.  Obviously, better names are required!

Original comment by chri...@chromium.org on 25 Mar 2011 at 1:30

GoogleCodeExporter commented 9 years ago 
Fixed in r226

Original comment by chri...@chromium.org on 25 Mar 2011 at 8:27