search

ericmckean / snappy

Automatically exported from code.google.com/p/snappy
Other
0 stars 0 forks source link

Makefile.am: snappy_unittest should be listed in check_PROGRAMS, not noinst_PROGRAMS #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Listing snappy_unittest in check_PROGRAMS means that it's only built as part of 
`make check`. `make all` builds things that are declared `noinst`, which is not 
the correct time to build a unittest, IMHO. See 
http://www.gnu.org/software/automake/manual/html_node/Uniform.html#index-check_0
05f-141

In particular, this stops it from trying to compile snappy_unittest (and 
possibly failing) if gtest isn't available.

Original issue reported on code.google.com by endgame....@gmail.com on 23 Mar 2011 at 12:02

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[Reposting with the right hat on]

Actually, snappy_unittest is more than just a test, despite the name; in 
particular, if you have the gflags package installed, it can be used for 
benchmarking. Thus, it's useful to have it built as part of make all. I'm 
closing this one (but thanks for all the others!).

Original comment by se...@google.com on 23 Mar 2011 at 12:16

GoogleCodeExporter commented 9 years ago 
Sure. Personally, I'd split that functionality out. That's your call, not mine.

Original comment by endgame....@gmail.com on 23 Mar 2011 at 12:19