search

ericmckean / snappy

Automatically exported from code.google.com/p/snappy
Other
0 stars 0 forks source link

configure.ac: macro calls may be underquoted #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
http://www.gnu.org/software/hello/manual/autoconf/Autoconf-Language.html

"""
Arguments should be enclosed within the quote characters ‘[’ and ‘]’, 
and be separated by commas.
"""

The page goes on to provide an example where quoting isn't require and goes on 
to say:

"""
Cautious Autoconf users would keep the quotes, but many Autoconf users find 
such precautions annoying...
"""

Personally, I am a cautious autoconf user, and wanted to bring this to your 
attention.

Original issue reported on code.google.com by endgame....@gmail.com on 22 Mar 2011 at 11:34

GoogleCodeExporter commented 9 years ago 
These are the calls to AC_CHECK_HEADERS(stdint.h stddef.h), 
AC_CHECK_FUNC(mmap), AC_SUBST([ac_cv_etc., and the four AC_SUBST() near the 
bottom, right? The m4_define, in particular, should stay as-is?

Original comment by sgunder...@bigfoot.com on 22 Mar 2011 at 11:39

GoogleCodeExporter commented 9 years ago 
Yes, but also the arguments to the AC_DEFINE calls. I'd quote the first 
argument to m4_define, because that's what the GNU M4 manual does: 
http://www.gnu.org/software/m4/manual/html_node/Define.html#Define

Note that autoconf changequotes to [] instead of `' for quotation.

Original comment by endgame....@gmail.com on 23 Mar 2011 at 12:13

GoogleCodeExporter commented 9 years ago

Original comment by se...@google.com on 23 Mar 2011 at 1:08

GoogleCodeExporter commented 9 years ago 
Fixed in r7.

Original comment by se...@google.com on 23 Mar 2011 at 11:13