search

ericmckean / snappy

Automatically exported from code.google.com/p/snappy
Other
0 stars 0 forks source link

Update configure.ac with AM_PROG_AR #67

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Try to run ./autogen.sh using the latest automake

The fix for this is just to add this to configure.ac:

    m4_pattern_allow([AM_PROG_AR])
    AM_PROG_AR

What is the expected output? What do you see instead?
/usr/share/automake-1.12/am/library.am: warning: 'libsnappy.a': linking 
libraries using a non-POSIX
/usr/share/automake-1.12/am/library.am: archiver requires 'AM_PROG_AR' in 
'configure.ac'

What version of the product are you using? On what operating system?
Lastest source from Subversion.
Mac OS 10.8.1

Please provide any additional information below.

Original issue reported on code.google.com by mike.naq...@gmail.com on 5 Sep 2012 at 8:08

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Hi,

I've looked a bit around online for this, and the consensus generally seems to 
be that AM_PROG_AR should be added in libtool, not in every configure.ac script 
out there. It's especially problematic as AM_PROG_AR doesn't exist in automake 
before 1.12, which means it breaks, among others, with the automake we use to 
build our distribution tarballs :-)

See e.g. http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11401 for a discussion.

As I understand it, this is just a warning, though, so it should be harmless 
for snappy?

Original comment by se...@google.com on 6 Sep 2012 at 11:55

GoogleCodeExporter commented 9 years ago 
It's just a warning, but by default warnings are treated as errors. I'm 
surprised (or maybe not so surprised:) that something like this exists in 
libtool to begin with.

Would it be worth noting somewhere that automake 1.12 can cause this warning?

Original comment by mike.naq...@gmail.com on 6 Sep 2012 at 12:59

GoogleCodeExporter commented 9 years ago 
Ah, yes, we run AM_INIT_AUTOMAKE with -Werror. Maybe the best thing to do here 
would simply be to remove -Werror. Does that fix your problem?

I'm not really sure where we'd want to document this. If anywhere, it should 
probably be in the automake 1.12 documentation, since Snappy is one of only 
many projects that seemingly are affected :-) My guess is, it's an issue with 
libtool that will be fixed quite soon, so it's rather transient.

Original comment by se...@google.com on 6 Sep 2012 at 1:02

GoogleCodeExporter commented 9 years ago 
I think removing -Werror would work.

Original comment by mike.naq...@gmail.com on 10 Sep 2012 at 1:19

GoogleCodeExporter commented 9 years ago 
Removing -Werror fixed my build problems on OS X 10.7.4.

Original comment by j...@somethingsimilar.com on 22 Sep 2012 at 5:02

GoogleCodeExporter commented 9 years ago 
Hi,

Sorry for being so slow about this, but you are not forgotten :-) The change to 
remove -Werror is in the pipeline.

Original comment by se...@google.com on 24 Sep 2012 at 9:16

GoogleCodeExporter commented 9 years ago 
Fixed in r68.

Original comment by se...@google.com on 8 Oct 2012 at 11:37