search

ericmckean / traceur-compiler

Automatically exported from code.google.com/p/traceur-compiler
Apache License 2.0
0 stars 0 forks source link

better repl #100

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
not sure how one makes pull requests with googlecode, hope this is good enough:)

commit:
https://code.google.com/r/amirjanyan-traceur-betterrepl/source/detail?r=0605e1a2
7325081af93de16f142732c6dfccb6c5

demo page:
http://amirjanyan-traceur-betterrepl.googlecode.com/git/demo/repl.html

what is changed:
use ace instead of textarea
save options into localStrorage
add easy way to load tests into editor

Original issue reported on code.google.com by Amirjanyan@gmail.com on 31 May 2012 at 8:35

GoogleCodeExporter commented 9 years ago 
This is really nice.

There are some things that need to be done for us to be able to accept this 
patch.

1. What license is ACE available under?

2. You need to sign the CLA

"Due to legal reasons, all contributors must sign a contributor license 
agreement, either for an individual 
(http://code.google.com/legal/individual-cla-v1.0.html) or corporation 
(http://code.google.com/legal/corporate-cla-v1.0.html), before a patch can be 
accepted."

And add your name to AUTHORS

3. Move the ace code into third_party

After that we can figure out how to do a code review and how to do pull requests

Original comment by arv@chromium.org on 31 May 2012 at 5:39

GoogleCodeExporter commented 9 years ago 
Hi Harutyun, I'll be glad to help with this patch after the bit above is 
complete.

BTW we are working on editor plugins for chrome devtools incl parser/compiler 
integration.  My goal is to get Traceur integrated incl sourcemaps and to get 
the repl UX in the debugger environment.  We have Orion and CodeMirror 
embedding in progress and I'd love to see ACE too....

Original comment by johnjbar...@google.com on 31 May 2012 at 6:25

GoogleCodeExporter commented 9 years ago 
Hi John

Ace is available under Mozilla tri-license (MPL/GPL/LGPL)
i've sent cla to cla-submissions@google.com, and updated the code 
(https://code.google.com/r/amirjanyan-traceur-betterrepl/source/detail?r=81d0d14
c4cae5f2df3117b916953e12c7984283a).

option to have ace in chrome devtools would be great, i'd love to help with that

Original comment by Amirjanyan@gmail.com on 2 Jun 2012 at 11:42

GoogleCodeExporter commented 9 years ago 
Harutyun, while I hesitate to put more hoops in your way, follow up on this 
work would be a ton easier if you could upload a patch via 'git cl':

https://code.google.com/p/traceur-compiler/wiki/GitWorkFlow

This tool is kinda like a client side pull request. It puts the patch up for 
comments then it is easy to commit it. 

Let me know if you have any problems.

Original comment by johnjbar...@chromium.org on 7 Jun 2012 at 10:25

GoogleCodeExporter commented 9 years ago 
Code patch on
http://codereview.appspot.com/6298064/

(BTW if you branch first then use git cl the patch will apply cleanly when we 
download it)

I've commit the change to aceREPL branch pending feedback from arv about the 
legal issues.

Original comment by johnjbar...@chromium.org on 8 Jun 2012 at 7:41

GoogleCodeExporter commented 9 years ago 
Just create a local branch. There is no need to create an upstream branch.

Original comment by arv@chromium.org on 8 Jun 2012 at 8:18

GoogleCodeExporter commented 9 years ago 
sorry for the delay,
i've fixed issues you've found a week ago but looks like i've messed up 
something with depot tools and pushed changes to another issue
http://codereview.appspot.com/6296076/

is there a way to push to the old one, or maybe you can merge from this?

Original comment by Amirjanyan@gmail.com on 23 Jun 2012 at 9:53

GoogleCodeExporter commented 9 years ago 
You can set the issue using

git cl issue 6298064

and then git cl upload

Original comment by arv@chromium.org on 24 Jun 2012 at 12:31

GoogleCodeExporter commented 9 years ago 
Did this ever get sent/landed?

Original comment by slightly...@google.com on 17 Oct 2012 at 11:22

GoogleCodeExporter commented 9 years ago 
We did land changes that do the following:

1. Use CodeMirror for syntax highlighting (sorry, I just found CM easier to use 
and its defaults better)
2. The content gets persisted in the URL fragment

The original patch had two more features:

3. It persisted the options
4. It provided a drop down menu which allowed you to insert the feature tests.

At this point I think we should close this and open new bugs if we want 3 or 4.

Original comment by arv@chromium.org on 17 Oct 2012 at 2:10

GoogleCodeExporter commented 9 years ago 
> sorry, I just found CM easier to use and its defaults better
indeed CM is smaller and have nicer api for setting options

> The original patch had two more features:
+ resizer, which can't be done with css only

anyway glad you replaced textarea
and sorry for wasting your time with this patch.

Original comment by Amirjanyan@gmail.com on 21 Oct 2012 at 7:49

GoogleCodeExporter commented 9 years ago 
https://code.google.com/p/traceur-compiler/source/detail?r=3a5e5bcf9573565a0da51
6ddd6dc5ec460153761

Debounce compile to make repl less laggy on slower computers

Original comment by arv@google.com on 25 Oct 2012 at 3:03

GoogleCodeExporter commented 9 years ago 
https://code.google.com/p/traceur-compiler/source/detail?r=12d6358

Side by side input and output

Original comment by arv@chromium.org on 25 Oct 2012 at 8:13