ericmckean / vogar

Automatically exported from code.google.com/p/vogar
0 stars 0 forks source link

Vogar w/ Android doesn't work on Windows #45

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. Try to run Vogar on Windows.

What do you see instead of the expected output?

* Vogar's AndroidSdk.java uses java.io.File which uses backslash. These paths 
do not work on Android. 

* AndroidSdk.java uses "which" to find adb. This works with Cygwin, but gives a 
Cygwin path which then causes this to return null:
new File(sdkRoot, "platforms").listFiles()
It should probably not be using "which" and then trying to guess where the SDK 
root is. It should just use an ANDROID_SDK_ROOT environment variable.

* AndroidSdk.java looks for "dx" and "aapt", but these are "dx.bat" and 
"aapt.exe".

What version of the product are you using? On what operating system?

SVN 221. Windows 7 64-bit.

Original issue reported on code.google.com by mapbench...@gmail.com on 28 Dec 2010 at 11:34

GoogleCodeExporter commented 9 years ago
Couple more:

* Console output doesn't have newlines, eg:
and push list←[0G←[Kexecuting mkdir

* I made the above changes to make it work on Windows, but get:
java.lang.NullPointerException
at java.io.File.<init>(File.java:305)
at vogar.HostFileCache.existsInCache(HostFileCache.java:65)
at vogar.Md5Cache.getFromCache(Md5Cache.java:43)
at vogar.android.AndroidSdk.dex(AndroidSdk.java:204)
at vogar.android.DeviceDalvikVm.dexAndPush(DeviceDalvikVm.java:80)
at vogar.android.DeviceDalvikVm.installRunner(DeviceDalvikVm.java:63)
at vogar.Mode.prepare(Mode.java:87)
at vogar.android.DeviceDalvikVm.prepare(DeviceDalvikVm.java:50)
at vogar.Driver.buildAndRun(Driver.java:114)
at vogar.Vogar.run(Vogar.java:532)
at vogar.Vogar.main(Vogar.java:541)

Original comment by mapbench...@gmail.com on 28 Dec 2010 at 11:50

GoogleCodeExporter commented 9 years ago
I'm happy to accept patches for Windows but I don't have access to a Windows 
machine to test this on. Patch submitters must agree to the Google CLA (which 
you can do online).

http://code.google.com/legal/individual-cla-v1.0.html

Original comment by limpbizkit on 29 Dec 2010 at 5:44