search

ericmckean / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

GWT tests do not restrict permutations properly #226

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Run a gwt test.

What is the expected output? What do you see instead?
Expected output is something within a few minutes.  Instead, it takes way too 
long, and even a trivial test can timeout due to the large number of default 
permutations that are being frivolously compiled.

The only permutations that should be used for GWT tests, if any, are user-agent 
permutations.  It's just not practical to have any more than that.

My suggestion is to be simple, and make all test modules declare explicitly the 
exact number of permutations in which it should run, by inheriting from 
restrictors that should be littered around a few top-level packages (e.g., 
OnePermutation.gwt.xml and AllPermutations.gwt.xml).  The default should always 
be OnePermutation.

Of course, nothing can enforce anything about the number of permutations that 
are used for a test, because of the brittleness and non-locality of how 
restrictions work with module definitions, but it should be an improvement.

Original issue reported on code.google.com by hearn...@google.com on 22 Feb 2011 at 12:18

GoogleCodeExporter commented 9 years ago 
edit: GWT tests are already restricted by user-agent, but all the other 
dimensions (locale, log-level, etc) are not necessarily restricted.

Original comment by hearn...@google.com on 22 Feb 2011 at 12:59