search

ericmckean / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

Shiny when cancel the addition of a gadget #227

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Click on puzzle icon to "Add gadget by URL."
2. Click on Cancel

What is the expected output? What do you see instead?
I get a shiny error and I should see nothing as I cancelled the gadget addition

Please provide any additional information below.
when I click on show details I get:
"Stack trace:
(TypeError): Cannot call method 'replace' of null
 stack: TypeError: Cannot call method 'replace' of null
    at iVb (http://waveinabox.net:9898/webclient/31B11AF09ABA0FE2867515DEC20EBC45.cache.html:2116:39)
    at AFd (http://waveinabox.net:9898/webclient/31B11AF09ABA0FE2867515DEC20EBC45.cache.html:3574:58)
    at Object.BFd (http://waveinabox.net:9898/webclient/31B11AF09ABA0FE2867515DEC20EBC45.cache.html:2159:51)
    at Object.QEd [as Zb] (http://waveinabox.net:9898/webclient/31B11AF09ABA0FE2867515DEC20EBC45.cache.html:3634:108331)
    at MW (http://waveinabox.net:9898/webclient/31B11AF09ABA0FE2867515DEC20EBC45.cache.html:2012:137)
    at Object.qX [as Mb] (http://waveinabox.net:9898/webclient/31B11AF09ABA0FE2867515DEC20EBC45.cache.html:2304:13664)
    at XMLHttpRequest.<anonymous> (http://waveinabox.net:9898/webclient/31B11AF09ABA0FE2867515DEC20EBC45.cache.html:1634:68)
    at DI (http://waveinabox.net:9898/webclient/31B11AF09ABA0FE2867515DEC20EBC45.cache.html:2126:61)
    at XMLHttpRequest.onreadystatechange (http://waveinabox.net:9898/webclient/31B11AF09ABA0FE2867515DEC20EBC45.cache.html:1675:45)
 type: non_object_property_call
 arguments: replace,
  Unknown.iVb (Unknown source:0)
  Unknown.AFd (Unknown source:0)
  Unknown.BFd (Unknown source:0)
  Unknown.QEd (Unknown source:0)
  Unknown.MW (Unknown source:0)
  Unknown.qX (Unknown source:0)
  Unknown.<anonymous> (Unknown source:0)
  Unknown.DI (Unknown source:0)
  Unknown.onreadystatechange (Unknown source:0)"

Original issue reported on code.google.com by pescamil...@gmail.com on 22 Feb 2011 at 4:35

GoogleCodeExporter commented 9 years ago 
Please review patch at: http://codereview.waveprotocol.org/549001

Original comment by vega113 on 24 Feb 2011 at 12:28

GoogleCodeExporter commented 9 years ago

Original comment by vega113 on 24 Feb 2011 at 12:28

GoogleCodeExporter commented 9 years ago 
fixed by a399edd669

Original comment by vega113 on 24 Feb 2011 at 6:40