search

ericmckean / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

Text inside blips is not wrapped #251

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The text inside blips is not wrapped, so if you type too much chars the the 
text overflows and is not rendered.
What steps will reproduce the problem?
1.Create a new blip.
2. Hit some key on the keyboard and keep pressing until the text reaches the 
end of the blip border.
What is the expected output? What do you see instead?
Expected: the text gets wrapped and excess chars rendered on a new line.
Actual: the text is not wrapped.

Original issue reported on code.google.com by vega113 on 4 Apr 2011 at 7:01

GoogleCodeExporter commented 9 years ago 
Note that cross-browser HTML support for breaking a single long word was quite 
limited back when we encountered this issue with Google Wave, and we decided 
just to let the text run over the edge (but be hidden).

Looking at the issue again, IE has { word-wrap: break-word; } for a while. I'm 
not sure what other browsers have support it, but it looks like it made it into 
CSS3:  http://www.w3.org/TR/2011/WD-css3-text-20110215/#word-wrap0

The union of CSS3-supporting browsers and IE probably covers everything worth 
caring about.

Original comment by hearn...@google.com on 5 Apr 2011 at 4:50

GoogleCodeExporter commented 9 years ago 
This issue seems to be adequate to be labeled as starter project.
Tip: take a look at: 
src/org/waveprotocol/wave/client/wavepanel/view/dom/full/Blip.css
Also, note that there is "mock" folder one level above that allows to play with 
blip mocks. First make changes on the mocks, and then also update the actual 
css.

Original comment by vega113 on 19 Apr 2011 at 9:25

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
There a problem with screenshot, I just see a text:
"Attachments:
       blip_word_wrap.png  20.1 KB"
without attachment.

Original comment by vega113 on 29 Apr 2011 at 8:11

GoogleCodeExporter commented 9 years ago 
Added a fix.
http://codereview.waveprotocol.org/585002

Original comment by gokul.je...@googlemail.com on 6 May 2011 at 3:30

GoogleCodeExporter commented 9 years ago 
Please add corresponding comment on the Wave Jira at 
https://issues.apache.org/jira/browse/wave

Original comment by vega113 on 6 May 2011 at 7:07