ericmckean / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

configure switch "--enable-onthefly-bitpacking" breaks libvpx-1.2.0 build (was ok in 1.1.0) #645

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This works:
./configure --enable-vp8 --enable-runtime-cpu-detect --enable-shared 
--enable-realtime-only

But this does not:
./configure --enable-vp8 --enable-runtime-cpu-detect --enable-shared 
--enable-realtime-only --enable-onthefly-bitpacking
make
(...)
    [CC] vp8/encoder/bitstream.c.o
In file included from ./vp8/common/common.h:15:0,
                 from vp8/encoder/bitstream.c:27:
vp8/encoder/bitstream.c: In function ‘vp8_update_coef_context’:
vp8/encoder/bitstream.c:1059:21: error: ‘VP8_COMP’ has no member named 
‘coef_counts’
         vp8_copy(cpi->coef_counts, default_coef_counts);
                     ^
vp8/encoder/bitstream.c:1059:9: note: in expansion of macro ‘vp8_copy’
         vp8_copy(cpi->coef_counts, default_coef_counts);
         ^
In file included from vp8/encoder/bitstream.c:27:0:
vp8/encoder/bitstream.c:1059:21: error: ‘VP8_COMP’ has no member named 
‘coef_counts’
         vp8_copy(cpi->coef_counts, default_coef_counts);
                     ^
./vp8/common/common.h:25:21: note: in definition of macro ‘vp8_copy’
         vpx_memcpy( Dest, Src, sizeof( Src)); \
                     ^
make[1]: *** [vp8/encoder/bitstream.c.o] Error 1
make: *** [.DEFAULT] Error 2

I don't really care much about this flag since I don't really understand what 
it does.
I just thought I would mention the bug since 1.2.0 causes these build failures 
on hosts that had been building 1.1.0 with the same configure options without 
problems.

Feel free to ignore or close the ticket.

Original issue reported on code.google.com by tot...@gmail.com on 14 Oct 2013 at 6:23

GoogleCodeExporter commented 9 years ago

Original comment by ya...@google.com on 17 Oct 2013 at 10:37

GoogleCodeExporter commented 9 years ago
The proposed fix is here: 
https://gerrit.chromium.org/gerrit/#/c/67547/

Original comment by ya...@google.com on 17 Oct 2013 at 11:05

GoogleCodeExporter commented 9 years ago

Original comment by ya...@google.com on 18 Oct 2013 at 12:19