search

ericmckean / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

vp8cx.h and vp8dx.h headers should include any other headers necessary to define required types #649

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I have a Chrome CL that needs to include vp8dx.h to get vp8 decoder 
functionality. It has to include like this:

extern "C" {    
#define VPX_CODEC_DISABLE_COMPAT 1  
#include "third_party/libvpx/source/libvpx/vpx/vpx_encoder.h"   
#include "third_party/libvpx/source/libvpx/vpx/vp8cx.h" 
}

The encoder header seems to be necessary to pull in the image structure 
definition, IIRC. Unfortunately this header order breaks Chrome's header 
ordering style.

Really vp8cx/hdx.h should include any necessary dependencies, though. :)

Original issue reported on code.google.com by wez@chromium.org on 21 Oct 2013 at 10:45

GoogleCodeExporter commented 9 years ago

Original comment by ya...@google.com on 9 Jan 2014 at 11:15