search

ericmckean / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

remove textrel's from 32-bit vp9 encoder #655

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
$ eu-findtextrel libvpx.so |sort -u
../vp9/encoder/x86/vp9_subpel_variance.asm not compiled with -fpic/-fPIC

Once the library is free of these a test should be added to the jenkins 
pre-submit

Original issue reported on code.google.com by jz...@google.com on 2 Nov 2013 at 4:22

GoogleCodeExporter commented 9 years ago 
Frank has a repro line for libvpx

Original comment by johannko...@google.com on 4 Nov 2013 at 4:51

GoogleCodeExporter commented 9 years ago 
eu-findtextrel works fine.

You could run this command line to check to see if there are any textrels. 
readelf -dW libvpx.so | grep TEXTREL | wc

Or this to get a count:
scanelf -qT libvpx.so.1.2.0 | wc

Original comment by fgalli...@google.com on 4 Nov 2013 at 5:56

GoogleCodeExporter commented 9 years ago 
Could you check if the patch (https://gerrit.chromium.org/gerrit/#/c/67765/) 
fixes the problem?

Original comment by yunqingw...@google.com on 6 Nov 2013 at 8:04

GoogleCodeExporter commented 9 years ago 
I added 'libvpx - sizes' to jenkins triggered for each patch:
http://build.webmproject.org/jenkins/job/libvpx%20-%20sizes/

It takes the artifacts from 'libvpx - compile options' and does the following:

for so in `find -name "*.so"`; do
  if readelf -dW $so | grep TEXTREL; then
    textrels=$(eu-findtextrel $so | sort | uniq)
    if [ -n "$textrels" ]; then
      echo "$textrels"
      exit 1
    fi
  fi
done

Original comment by jz...@chromium.org on 13 Nov 2013 at 7:04

GoogleCodeExporter commented 9 years ago 
https://gerrit.chromium.org/gerrit/#/c/67765/

has been merged.

Original comment by jz...@google.com on 13 Nov 2013 at 7:05