Decoder produces mismatched outputs with ssse3 enabled and disabled.

ericmckean / webm

Automatically exported from code.google.com/p/webm

0 stars 0 forks source link

Decoder produces mismatched outputs with ssse3 enabled and disabled. #661

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

vp9    - WebM Project VP9 Decoder v1.2.0-5005-gaf2559c

Following configuration fails to correctly decode the attached lossless stream. 
Small pixel errors in decoded yuv.

Configuring selected codecs
  enabling vp8_encoder
  enabling vp8_decoder
  enabling vp9_encoder
  enabling vp9_decoder
Configuring for target 'x86_64-linux-gcc'
  enabling x86_64
  enabling runtime_cpu_detect
  enabling mmx
  enabling sse
  enabling sse2
  enabling sse3
  enabling ssse3
  enabling sse4_1
  enabling avx
  using yasm
  checking here for x86inc "x86_64" "" 
  enabling use_x86inc
  enabling postproc
  enabling unit_tests

./configure --target=generic-gnu works ok.

Original issue reported on code.google.com by attilan...@google.com on 11 Nov 2013 at 8:31

Attachments:

stream.vp9

GoogleCodeExporter commented 9 years ago

This configuration works -> problem in ssse3 asm code

./configure  --disable-ssse3
Configuring selected codecs
  enabling vp8_encoder
  enabling vp8_decoder
  enabling vp9_encoder
  enabling vp9_decoder
Configuring for target 'x86_64-linux-gcc'
  enabling x86_64
  enabling runtime_cpu_detect
  enabling mmx
  enabling sse
  enabling sse2
  enabling sse3
  enabling sse4_1
  enabling avx
  using yasm
  checking here for x86inc "x86_64" "" 
  enabling use_x86inc
  enabling postproc
  enabling unit_tests

Original comment by attilan...@google.com on 11 Nov 2013 at 8:48

GoogleCodeExporter commented 9 years ago

Original comment by attilan...@google.com on 12 Nov 2013 at 9:45

GoogleCodeExporter commented 9 years ago

I'm assuming the expected md5 is b5712c5cf595420b783c242b80deb69a and the bad 
one is 94d75b107d353806de149c2db8771f0b

It appears to stem from issues in vp9_convolve8_horiz_ssse3 and 
vp9_convolve8_ssse3

I haven't bisected.

Original comment by johannko...@google.com on 12 Nov 2013 at 9:58

GoogleCodeExporter commented 9 years ago

Original comment by johannko...@google.com on 12 Nov 2013 at 9:59

GoogleCodeExporter commented 9 years ago

Could you find the encoding settings that produced this bit-stream? Thanks.

Original comment by jingn...@google.com on 13 Nov 2013 at 8:32

GoogleCodeExporter commented 9 years ago

--frame-parallel=1 --passes=1 --tile-columns=0 --tile-rows=1 --lossless=1 
--error-resilient=1 --min-q=0 --max-q=0 --kf-min-dist=2 --kf-max-dist=2 -D 
--cpu-used=0 --codec=vp9 --psnr --good --verbose --ivf --output=stream.vp9 
--fps=25/1 --width=320 --height=180 --limit=20 
jaakiekko_noise_25fps_w320h180.yuv

Original comment by attilan...@google.com on 14 Nov 2013 at 6:32

GoogleCodeExporter commented 9 years ago

Original comment by ya...@google.com on 18 Nov 2013 at 7:01

Changed state: Assigned

GoogleCodeExporter commented 9 years ago

It

Original comment by ya...@google.com on 18 Nov 2013 at 7:03

Changed title: _Decoder produces mismatched outputs with ssse3 enabled and disabled. _

GoogleCodeExporter commented 9 years ago

Original comment by yunqingw...@google.com on 18 Nov 2013 at 8:16

Changed state: Started

GoogleCodeExporter commented 9 years ago

The fix is at https://gerrit.chromium.org/gerrit/#/c/67868/2

Attila, thanks for catching the bug.

Original comment by yunqingw...@google.com on 20 Nov 2013 at 12:17

GoogleCodeExporter commented 9 years ago

Nice! Noise rules! ;)

Original comment by attilan...@google.com on 20 Nov 2013 at 6:39

GoogleCodeExporter commented 9 years ago

Original comment by yunqingw...@google.com on 20 Nov 2013 at 4:35

Changed state: Fixed