ericmckean / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

investigate obj_int_extract removal #710

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It's a complication in the build process that has to be dealt with in each new 
build system. It isn't clear what the current performance benefits are either. 
If the loss is small, I'd prefer to see this removed.

Original issue reported on code.google.com by jz...@google.com on 20 Feb 2014 at 10:04

GoogleCodeExporter commented 9 years ago
Johann, can you take a look at this? Or is it more appropriate for Yunqing?

Original comment by jz...@google.com on 20 Feb 2014 at 10:04

GoogleCodeExporter commented 9 years ago
It's my fault it's there for x86.

Original comment by johannko...@google.com on 20 Feb 2014 at 10:22

GoogleCodeExporter commented 9 years ago
Do we have any performance numbers demonstrating that it's worthwhile to bother 
with obj_int_extract on any platform? If it's only going to hit us for say, 2%, 
why don't we just get rid of it entirely? 

We're fast enough on x86/x86_64, and I think we can probably find a couple 
percentage points elsewhere on arm targets.

Original comment by tomfine...@google.com on 14 May 2014 at 5:48

GoogleCodeExporter commented 9 years ago
They are almost out for x86. Just one function left, sse4 quantize. arm needs 
some benchmarking. The neon functions should be able to switch to intrinsics 
but pack_tokens will need some investigatoin.

Original comment by johannko...@google.com on 14 May 2014 at 6:29

GoogleCodeExporter commented 9 years ago

Original comment by johannko...@google.com on 10 Jul 2014 at 5:43

GoogleCodeExporter commented 9 years ago
x86 offsets are gone. Working on vpx_scale.

We may keep the pack_tokens code but remove it from most popular configurations.

Original comment by johannko...@google.com on 10 Jul 2014 at 5:45

GoogleCodeExporter commented 9 years ago
Removal soon.

Original comment by johannko...@google.com on 6 Nov 2014 at 1:23

GoogleCodeExporter commented 9 years ago
Removed. Some old files left floating around because WebRTC uses them for the 
Chromium build.

Original comment by johannko...@google.com on 26 Nov 2014 at 7:56