search

ericmckean / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

VP8 neon code clean up #725

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
After adding neon register state check in unit test, there is a VP8 neon code 
failure comes from sixtappredict**.asm. The reason is because the saving of 
neon register is not done inside the neon assembly, but outside in the C code. 
This must be cleaned up.

Things need to do:
1. Move the push neon operation in VP8 from C code into neon code.
2. Merge vp8_push_neon with vp9_push_neon into one vpx_push_neon as they are 
totally the same function.

Original issue reported on code.google.com by hku...@google.com on 7 Mar 2014 at 7:01

GoogleCodeExporter commented 9 years ago

Original comment by hku...@google.com on 7 Mar 2014 at 7:02

GoogleCodeExporter commented 9 years ago 
This file was deleted in:
https://gerrit.chromium.org/gerrit/#/c/68178/
08e38f0 VP8 for ARMv8 by using NEON intrinsics 14

is there anything else to do here?

Original comment by jz...@google.com on 16 Jul 2014 at 5:39

GoogleCodeExporter commented 9 years ago 
FWIW, I had to revert "08e38f0 VP8 for ARMv8 by using NEON intrinsics 14" to 
avoid hitting an unaligned access: 
https://code.google.com/p/webm/issues/detail?id=817

Original comment by tomtheen...@gmail.com on 16 Jul 2014 at 5:47

GoogleCodeExporter commented 9 years ago 
Neon registers are stored in the assembly code now. vp8_push_neon was removed 
already. I think we could close this issue as fixed.

Original comment by yunqingw...@google.com on 16 Jul 2014 at 6:03

GoogleCodeExporter commented 9 years ago

Original comment by yunqingw...@google.com on 17 Jul 2014 at 6:32