ericmckean / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

Fails to build with clang trunk #729

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Clang will parse inline assembly, so the vp8_asm_enc_offsets trick doesn't work.

One option is to turn it into valid assembly. The other is to disable the 
integrated assembler (with a check for -fno-integrated-as being supported)

diff --git a/build/make/Makefile b/build/make/Makefile
index dd7fb4a..f28ff15 100644
--- a/build/make/Makefile
+++ b/build/make/Makefile
@@ -168,7 +168,7 @@ $(BUILD_PFX)%.s.o: %.s
        $(qexec)$(AS) $(ASFLAGS) -o $@ $<

 .PRECIOUS: %.c.S
-%.c.S: CFLAGS += -DINLINE_ASM
+%.c.S: CFLAGS += -DINLINE_ASM -fno-integrated-as
 $(BUILD_PFX)%.c.S: %.c
        $(if $(quiet),@echo "    [GEN] $@")
        $(qexec)$(CC) -S $(CFLAGS) -o $@ $<

Original issue reported on code.google.com by rafael.e...@gmail.com on 12 Mar 2014 at 4:11

GoogleCodeExporter commented 9 years ago

Original comment by renganat...@google.com on 3 Apr 2014 at 10:28

GoogleCodeExporter commented 9 years ago
This is related to the issue with ticket 708 it seems. The patch provided seems 
to work as a workaround and I can now build libvpx.

Original comment by brad.ope...@gmail.com on 20 Apr 2014 at 8:10

GoogleCodeExporter commented 9 years ago
We are in the process of removing asm_offsets.

Original comment by johannko...@google.com on 10 Jul 2014 at 5:43