libvpx doesn't link when optimization set to "max" on Windows

[GoogleCodeExporter]

If I add "optimize=max" 
(https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&l=
4577) to my GYP defines I get the following errors building libvpx:

[58/196] RULE Compile assembly source\libvpx\vp8\encoder\x86\quantize_ssse3.asm
FAILED: D:\src\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper 
environment.x86 
libvpx_target_assemble_dd516f75518765ebf26fc03c14521b09.39f6b7e4fcadf09f8edf05c9
135fd327.rsp ..\..\third_party\libvpx
source\libvpx\vp8\encoder\x86\quantize_ssse3.asm:50: error: undefined symbol 
`vp8_block_coeff' (first use)
source\libvpx\vp8\encoder\x86\quantize_ssse3.asm:50: error:  (Each undefined 
symbol is reported only once.)
source\libvpx\vp8\encoder\x86\quantize_ssse3.asm:51: error: undefined symbol 
`vp8_block_round' (first use)
source\libvpx\vp8\encoder\x86\quantize_ssse3.asm:52: error: undefined symbol 
`vp8_block_quant_fast' (first use)
source\libvpx\vp8\encoder\x86\quantize_ssse3.asm:79: error: undefined symbol 
`vp8_blockd_qcoeff' (first use)
source\libvpx\vp8\encoder\x86\quantize_ssse3.asm:80: error: undefined symbol 
`vp8_blockd_dequant' (first use)
source\libvpx\vp8\encoder\x86\quantize_ssse3.asm:81: error: undefined symbol 
`vp8_blockd_dqcoeff' (first use)
source\libvpx\vp8\encoder\x86\quantize_ssse3.asm:110: error: undefined symbol 
`vp8_blockd_eob' (first use)
[58/196] RULE Compile assembly source\libvpx\vp8\encoder\x86\quantize_sse4.asm
FAILED: D:\src\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper 
environment.x86 
libvpx_target_assemble_dd516f75518765ebf26fc03c14521b09.4ab189601b830a3f300f56ad
7d764333.rsp ..\..\third_party\libvpx
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:55: error: undefined symbol 
`vp8_block_coeff' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:55: error:  (Each undefined 
symbol is reported only once.)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:56: error: undefined symbol 
`vp8_block_zbin' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:57: error: undefined symbol 
`vp8_block_round' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:58: error: undefined symbol 
`vp8_block_zbin_extra' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:102: error: undefined symbol 
`vp8_block_quant_shift' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:103: error: undefined symbol 
`vp8_block_quant' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:104: error: undefined symbol 
`vp8_block_zrun_zbin_boost' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:177: error: undefined symbol 
`vp8_blockd_dequant' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:178: error: undefined symbol 
`vp8_blockd_dqcoeff' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:198: error: undefined symbol 
`vp8_blockd_qcoeff' (first use)
source\libvpx\vp8\encoder\x86\quantize_sse4.asm:211: error: undefined symbol 
`vp8_blockd_eob' (first use)
[58/196] RULE Compile assembly source\libvpx\vp9\encoder\x86\vp9_sad4d_sse2.asm
ninja: build stopped: subcommand failed.

Original issue reported on code.google.com by sebmarchand@chromium.org on 17 Mar 2014 at 2:45

[GoogleCodeExporter]

This is a duplicate of 
https://code.google.com/p/chromium/issues/detail?id=352476

Original comment by sebmarchand@chromium.org on 17 Mar 2014 at 2:45

[GoogleCodeExporter]

Original comment by renganat...@google.com on 3 Apr 2014 at 10:26

• Changed state: Available
• Added labels: Pri-3

[GoogleCodeExporter]

Moved to intrinsics for those functions and removed the offsets.

Original comment by johannko...@google.com on 6 Nov 2014 at 1:09

• Changed state: Fixed