search

ericmerrill / Banner-Luminis-Message-Broker-for-Moodle

A plugin for Moodle to import Banner/Luminis Message Broker data
13 stars 8 forks source link

When processing xml file and usemoodlecoursesettings is set, courses have incorrect settings #12

Closed mspall closed 8 years ago

mspall commented 8 years ago

When processing xml file and usemoodlecoursesettings is set courses have incorrect settings. The courses have neither the default course setting options found in the Moodle admin settings nor the settings hard-coded in this module. The settings are the database field defaults. An example is mdl_course.newsitems. We have set that to 2 in default course settings. It is hard coded as 3 in the module. The actual courses has it set to 1, which is the field default in the database.

ericmerrill commented 8 years ago

What version of the plugin are you using?

mspall commented 8 years ago

The latest release branch with last commit "Version bump to 3.0.0" on on Feb 10, 2016. We are using Moodle 3.0.3+ (Build: 20160324)

ericmerrill commented 8 years ago

Do you have computesections and forcecomputesectiosn off in the Moodle LMB config?

mspall commented 8 years ago

I have computesections on and forcecomputesections off.

ericmerrill commented 8 years ago

I'll get back to you.

mspall commented 8 years ago

I found the error. It is a simple typo in lib.php. I will make a pull request in a few minutes.

ericmerrill commented 8 years ago

Very sorry for the delay here. Release 3.0.1 today.