ericmerrill / moodle-mod_webexactivity

A Cisco WebEx activity module for Moodle
https://moodle.org/plugins/view.php?plugin=mod_webexactivity
9 stars 13 forks source link

WebEx Template and bulk recording deletion #9

Closed programming2web closed 7 years ago

programming2web commented 8 years ago

Allows to indicate a standard template from WebEx to control new meetings settings such as audio conference, attendee privileges, meeting options, etc.

Adds a column with checkboxes to admin Manage Recordings page which allows to bulk delete the selected recordings.

ericmerrill commented 7 years ago

Thanks @programming2web! Sorry for the long delay.

Initial look is good, except the bulk delete needs to have logging implemented (and indent level fixed) where your todo it.

programming2web commented 7 years ago

Thanks, Eric! I've added logging and fixed indentation. Also added a course column to admin recordings list as it is helpful to see that info besides recording name when deciding which recordings to delete.

ericmerrill commented 7 years ago

I've merged your first 3 commits into master. The indenting still looks messed up in your last commit (Moodle doesn't use tabs, it uses 4 spaces per indent), plus there were some other minor code style issues, so I fixed those as well.

I'll merge them into the release branches when I make a new release.

programming2web commented 7 years ago

Thank you, Eric! Appreciate your note about the indents, I'll use 4 spaces in the future.