search

ericmjl / hiveplot

Hive Plots in using Python & matplotlib!
MIT License
70 stars 15 forks source link

Test notebook produces different output #9

Open leotrs opened 8 years ago

leotrs commented 8 years ago

The Tests notebook produces a different result on my local repo than the one on the example. I think it has to do with the order of the nodes in every axis.

2016-07-27-191945_720x530_scrot

If labeled as a bug, I can try to prepare a patch.

ericmjl commented 8 years ago

I wouldn't worry too much about this; dictionary accesses are random, and the underlying NetworkX graph is a dictionary. As I prepare to move the codebase into nxviz, I think it'd be helpful to institute some image diff tests, so guaranteeing that the images look identical would be helpful! :smile:

(btw, don't worry about the migration for now, I'm still going to leave the hiveplot package around, and will make sure that nxviz's hiveplot implementation is identical to this repo.)

leotrs commented 8 years ago

+1 image diffs

Also, nxviz sounds really interesting, I think I'll focus my efforts there instead.