search

ericmmartin / simplemodal

A modal dialog framework for jQuery
http://simplemodal.com/
Other
507 stars 229 forks source link

fix for latest versions of jQuery #33

Closed mattwill09 closed 10 years ago

mattwill09 commented 11 years ago

support.boxModel has been removed from the latest versions of jQuery http://bugs.jquery.com/ticket/13743

change to check if support.boxModel exists as part of the browser.ieQuirks test

ukilon-okta commented 11 years ago

Do you have an ETA on merging this?

ericmmartin commented 11 years ago

There was as similar fix suggested on SO (http://stackoverflow.com/a/18022855/40749). Any feedback on which fix to use?

mattwill09 commented 11 years ago

Honestly, either one of them is probably perfectly fine. I may be a bit biased but if Microsoft ever decided to stop populating that flag you would be back to getting exceptions whereas my solution relies entirely upon jQuery and we are looking to see if something exists before checking it so that will never break.

withoutthea commented 10 years ago

This bug just jumped up and gave me a little bite. Any ETA on merging in the fixes?

cantonbecker commented 10 years ago

FYI I downgraded from using jQuery 1.11.0 to 1.9.1 because I rely on SimpleModal, and IE9 was throwing "Object doesn't support property or method 'removeExpression'."

crccheck commented 10 years ago

+1

I hate +1 comments, but c'mon, it's been almost a year

crccheck commented 10 years ago

Actually, I just tried out the unreleased v1.4.5 in master and it seems to have fixed this a slightly different way.