Modernized version of SimpleModal

ericmmartin / simplemodal

A modal dialog framework for jQuery

http://simplemodal.com/

Other

506 stars 229 forks source link

Modernized version of SimpleModal #51

Closed shadowhand closed 10 years ago

shadowhand commented 10 years ago

remove all browser-specific hacks and references to specific browsers
remove all positioning and dimension setting code
remove all options to do with width/height control
remove the .simplemodal-wrap element from HTML

By realizing these changes, it is possible to control modals entirely using CSS, without having to negate the styles that SimpleModal applies by default. Removing large blocks of code for legacy browsers makes SimpleModal even faster.

cc @rjmackay @dkobia

chenghong commented 10 years ago

With this version, does it still support IE7?

shadowhand commented 10 years ago

@chenghong It is completely browser agnostic, relying on the end developer to implement CSS positioning for the modal. Typically this would involve using position: fixed, which is not supported by IE7, but there is a polyfill available.