search

ericniebler / meta

A tiny metaprogramming library
Boost Software License 1.0
302 stars 47 forks source link

partition is slow #52

Open ldionne opened 6 years ago

ldionne commented 6 years ago

Metabench is timing out because of it: https://travis-ci.org/ldionne/metabench/jobs/294051656#L1991

Also, graphs agree with this: http://metaben.ch/type/clang++-4.0/partition/index.html

It's fine if there's no desire to make it faster, but I'll reduce its range from Metabench to avoid timing out. Just let me know.

gnzlbg commented 6 years ago

@ldionne PR welcome :D

gnzlbg commented 6 years ago

This doesn't make metabench time out any more thanks to @ldionne 's patch but partition in meta still seems to be very slow compared to the other libraries.

ldionne commented 6 years ago

I'm sorry, I don't have the bandwidth to provide a PR for fixing this at the root in meta. That's why I just put a band-aid by fixing metabench. Also, FWIW, this seems to be an interaction between meta and GCC 7, since I think partition is not as slow on other compilers. There may be something interesting to report to the GCC folks.

Anyway, if this is fixed properly in meta and you want me to re-increase the range in metabench, just LMK.

CaseyCarter commented 6 years ago

I'm sorry, I don't have the bandwidth to provide a PR for fixing this at the root in meta.

Re-opening the issue is not a suggestion that you should fix it, but that someone probably should.

ldionne commented 6 years ago

I understand that; I was rationalizing my initial closing of the issue.

gnzlbg commented 6 years ago

Yes I did not meant to say that you should fix it. I just don't want to "forget" that this happens. Thanks for reporting this!