search

ericpaulbishop / gargoyle

Gargoyle Router Management Utility
http://www.gargoyle-router.com
470 stars 221 forks source link

Manual changes to /etc/hosts are reverted on DHCP > Save Changes #1009

Open bbecker-inlogik opened 3 months ago

bbecker-inlogik commented 3 months ago

Steps to reproduce issue:

The createHostCommands variable should be removed completely, since DHCP configuration no longer lives in /etc/hosts there is no need to revert this file to factory setting.
https://github.com/ericpaulbishop/gargoyle/blob/ae547ce5113ce1c6e260112bcdcab9f41e3e7ab8/package/gargoyle/files/www/js/dhcp.js#L105

lantis1008 commented 3 months ago

Thanks for reporting, I will consider a fix. We do place local host information in there intentionally so there is still a requirement.

bbecker-inlogik commented 3 months ago

Perhaps rather than clearing the file, it could append the localhost lines only if they are are missing.