search

ericpaulbishop / gargoyle

Gargoyle Router Management Utility
http://www.gargoyle-router.com
470 stars 221 forks source link

adblock in CC #502

Open obsy opened 8 years ago

obsy commented 8 years ago

Now we have adblock in CC (https://github.com/openwrt/packages/commit/081f255ac3977800bd9281cc04691f15949f1f64).

Did you consider supporting this package in plugin-gargoyle-adblock?

lantis1008 commented 8 years ago

That package is really bloated. Don't get me wrong it's a good implementation, but it's over the top for what it is. I don't think you really need a daemon running looking for updates or anything, the lists just aren't that frequent. His auto setup of interfaces is nice though.

Did you have anything in particular you wanted from it?

On 17 Mar 2016, at 4:05 AM, Cezary Jackiewicz notifications@github.com wrote:

Now we have adblock in CC (openwrt/packages@081f255 https://github.com/openwrt/packages/commit/081f255ac3977800bd9281cc04691f15949f1f64).

Did you consider supporting this package in plugin-gargoyle-adblock?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/ericpaulbishop/gargoyle/issues/502

obsy commented 8 years ago

Keep those same solutions without duplicating packages/functionality.

lantis1008 commented 8 years ago

I guess so. I like his firewall implementation better then mine, but it won't play nicely with gargoyle I don't think.

If people think it's worth doing I'll look but I'm not keen.

ericpaulbishop commented 8 years ago

I would be open to having multiple packages with an adblock solution, one that is the old way, one with the new package if you want to create a new plugin based on the openwrt package.

That said, given that Lantis built and is maintaining that plugin, and it isn't part of the core set of packages, I'm going to go with whatever he wants to do for his plugin.