search

ericpaulbishop / gargoyle

Gargoyle Router Management Utility
http://www.gargoyle-router.com
470 stars 221 forks source link

Spring Cleaning #526

Open nworbnhoj opened 8 years ago

nworbnhoj commented 8 years ago

@lantis1008 suggested that we need to do a bit of Spring Cleaning before the next stable release so here is a list of known bugs that we can check-off. Please reply below if you have a bug to add or are working on one of the bugs. I will tick them off as we go.

lantis1008 commented 8 years ago

Please add: Using quotas to throttle without using QOS causes crashes for most users. File share passwords reset on sysupgrade with preserve settings. Not sure if this is fixable.

^ I'll look at the file share one because I can definitely reproduce it.

ericpaulbishop commented 8 years ago

Thank you for putting this list together -- identifying these little issues reported on the forum and putting them together into a single list like this is very helpful.

However, I edited your comment to remove subnet bandwidth monitoring -- this isn't really technically possible. Once a connection has been NATed it's not possible to monitor outside the router that's doing the NATing.

nworbnhoj commented 8 years ago

@ericpaulbishop not problem, I had not yet thought the subnet issue thru, but I knew it was an open issue on the forum.

lantis1008 commented 8 years ago

Can check off "File Share User Passwords" after #527 is accepted.

lantis1008 commented 8 years ago

i would consider #523 and #528 spring cleaning. I'll handle them both. Fixed in #536

lantis1008 commented 8 years ago

I can't seem to debug the quota crash issue. Steps to replicate.

  1. Setup quota that will expire soon (e.g. max download 1MB)
  2. Set to throttle download and upload speeds (100KB/s for example)
  3. Apply
  4. Launch youtube on device that is under the rule. Watch video. Crashes within 10 seconds. @ericpaulbishop i defer to you on this one sorry.
ericpaulbishop commented 8 years ago

I am looking into the quota crash issue now. Thank you for looking into it, confirming it, and providing steps to consistently replicate. That helps, a LOT.

ericpaulbishop commented 8 years ago

The quota QoS was an IMQ issue -- the latest updates to the IMQ patch were causing it to crash. Reverting the updates fixes the issue.

lantis1008 commented 8 years ago

I figured it was imq. Have you try the newest patches MINUS the ones I added for multiple queue support?

lantis1008 commented 8 years ago

Interestingly we added those patches to help a previous issue someone was having with IMQ

ericpaulbishop commented 8 years ago

I'm pretty sure I could add back the multiple queue support, though I took it out to be sure. It's the other patch that's really problematic, the one that moves the destructor.

lantis1008 commented 8 years ago

I did a diff against the 4.4 config and they used the new destructor location as well I believe.

Maybe a reversion and wait for complaints to resurface is the best action here.

rpodric commented 8 years ago

@ericpaulbishop Re "Once a connection has been NATed it's not possible to monitor outside the router that's doing the NATing," I'm wondering if you're referring to a multiple router setup. The word "outside" makes me think that, but maybe you mean in it a way that I just don't understand (I didn't see the original comment to provide context).

On a single-router Gargoyle 1.9.1 setup, I enabled Guest wifi using Steps 1-4a (slightly tweaked) of this: https://wiki.openwrt.org/doc/recipes/guest-wlan

It allows Guest wifi to be on an independent subnet. Bandwidth Usage/Distribution ignore the Guest subnet, however (it does show up in Connected Hosts).

Is that scenario also not possible? Thanks.