search

ericpaulbishop / gargoyle

Gargoyle Router Management Utility
http://www.gargoyle-router.com
468 stars 221 forks source link

default timeserver setting seems duplicate #825

Closed crackself closed 5 years ago

crackself commented 5 years ago

there‘s 019-start_sysntpd_sooner.patch for modify openwrt default timeserver.Besides, gargoyle package have configration also make change of this

ntp_section=$(uci get system.ntp 2>/dev/null)
if [ "$ntp_section" != "timeserver" ] ; then
    uci del system.ntp 2>/dev/null
    uci set system.ntp="timeserver"                 2>/dev/null
    uci add_list system.ntp.server="0.pool.ntp.org" 2>/dev/null
    uci add_list system.ntp.server="1.pool.ntp.org" 2>/dev/null
    uci add_list system.ntp.server="2.pool.ntp.org" 2>/dev/null
fi

should we remove one ?

lantis1008 commented 5 years ago

Yes probably can remove the one in uci defaults. If you want to test no regression on initial flash/sysupgrade (preserved and unpreserved) and make a PR i'll be happy to merge it.