Fix Router Access page - Githubissues

n3vu0r commented 4 years ago

Update UCI after saving changes w/o redirect

In contrast to basic.js, access.js misses to update uciOriginal after saving changes without redirect. Resetting data afterwards results in disabling all remote_accepts (Remote Web Access and Remote SSH Access) because when saving changes, the old firewall sections are deleted from uciOriginal before it is cloned into uci to which the new firewall sections are added. But in the end, uciOriginal must be updated to uci to reflect all the changes including the new firewall sections.

Found some other issues, more commits coming.

lantis1008 commented 4 years ago

Also your other code changes will go in this weekend, have not forgotten.

lantis1008 commented 4 years ago

Thanks.

Just a reminder, preferably new changes go into master, as that is where the future of Gargoyle lies. If you would like the change backported to 1.12 as well, please let me know in the pull request and i'll organise it. It is easier for me to go backwards rather than forwards in these cases.

n3vu0r commented 4 years ago

Good to know, thanks!

ericpaulbishop / gargoyle

Fix Router Access page #854