search

ericpaulbishop / gargoyle

Gargoyle Router Management Utility
http://www.gargoyle-router.com
467 stars 221 forks source link

JS files not minified on Archer C2600 (ipq806x) using 1.13.X factory image #924

Closed d3fz closed 3 years ago

d3fz commented 3 years ago

After flashing Gargoyle for the first time on a C2600, using the factory image from 1.13.X (Built 20210126-1716 git@0c75cab9) build, I've noticed that none of the JS files in www/js were minified. But all CSS files in www/themes were (but not theme.js).

After that, I did a clean sysupgrade using the image from 1.13.X (Built 20210319-0339 git@396836cd) build, and all JS/CSS files were minified, as expected. Including theme.js.

Did a quick folder size comparison on www/js afterwards, and I was really impressed to see that the changes from #860 made a ~370kB difference in size. That's quite a lot, actually.

Nice!

lantis1008 commented 3 years ago

Hey, i'm not seeing this on the latest builds, factory or sysupgrade. I'd suggest that this isn't an error and more an artifact of one of the community builds "build environment".

d3fz commented 3 years ago

I understand.

Thank you for your feedback.

Closing issue.