plugin-gargoyle-ping-watchdog: Add IPv6 support

ericpaulbishop / gargoyle

Gargoyle Router Management Utility

http://www.gargoyle-router.com

468 stars 221 forks source link

plugin-gargoyle-ping-watchdog: Add IPv6 support #928

Closed lantis1008 closed 3 years ago

lantis1008 commented 3 years ago

Please review @obsy as it is your plugin originally 😄

obsy commented 3 years ago

Looks good, but... Should be wan6 raised, if wan6 is disabled in config?

lantis1008 commented 3 years ago

I'll check, i thought if the iface was disabled, ifup did nothing?

obsy commented 3 years ago

Disabled by setting ipv6=0 in wan secition. I don't use ipv6, I can't test this.

lantis1008 commented 3 years ago

I tested this, and ifup wan6 did nothing on a device where network.wan.ipv6=0 (besides a bit of log spam). I think for now this is ok? Your call. If you want it changed i'll change it. :)

obsy commented 3 years ago

LGTM